gcp-o11y: add sleep in Observability close() #9972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Mar 21, 2023
| Thread.sleep( | ||
| TimeUnit.MILLISECONDS.convert(2 * METRICS_EXPORT_INTERVAL, TimeUnit.SECONDS)); | ||
| } catch (InterruptedException e) { | ||
| logger.log(Level.SEVERE, "Caught exception during sleep", e); |
There was a problem hiding this comment.
Add Thread.currentThread().interrupt()
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Mar 23, 2023
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Mar 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sleep in
close()for metrics and/or traces to be flushed before closing observability.Currently sleep is set to 2 * [Metrics export interval (30 secs)].
CC @sanjaypujare @ejona86
CC @stanley-cheung : this might alter inter-op tests results