Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add gcp-observability examples (v1.54.x backport) #9987

Merged
merged 2 commits into from
Mar 23, 2023

Conversation

DNVindhya
Copy link
Contributor

Backport of #9967 to v1.54.x.

This PR adds gcp-observability example based on HelloWorld.

CC @sanjaypujare @ejona86 @fengli79

* add examples for gcp-observability

// Feel free to delete the comment at the next line. It is just for safely
// updating the version in our release process.
def grpcVersion = '1.55.0-SNAPSHOT' // CURRENT_GRPC_VERSION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct. A 1.54.x example cannot depend on 1.55.0-SNAPSHOT . Pls look at other examples in 1.54.x branch and see what dependency they have in their gradle file. Pls also check all the other version numbers for consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to 1.54.0-SNAPSHOT as in other examples. Also verified other version numbers, they are set similar to other examples.

Copy link
Contributor

@sanjaypujare sanjaypujare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanjaypujare sanjaypujare merged commit fefa2d9 into grpc:v1.54.x Mar 23, 2023
@DNVindhya DNVindhya deleted the backport-1.54-gcp-o11y-examples branch March 24, 2023 20:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants