Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing class exports #1164

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Add missing class exports #1164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/grpc-web/exports.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@
*/
goog.module('grpc.web.Exports');

const CallOptions = goog.require('grpc.web.CallOptions');
const MethodDescriptor = goog.require('grpc.web.MethodDescriptor');
const GrpcWebClientBase = goog.require('grpc.web.GrpcWebClientBase');
const RpcError = goog.require('grpc.web.RpcError');
const StatusCode = goog.require('grpc.web.StatusCode');
const MethodDescriptor = goog.require('grpc.web.MethodDescriptor');
const MethodType = goog.require('grpc.web.MethodType');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do you mind help sort this line as well? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order reflects exports from index.d.ts? Is this ok?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for the considerations :)

Personally i still prefer the exports to be alphabetically ordered in this file, given the connection to index.d.ts is an obscure one and would be harder to maintain (especially if we don't even document it here).

But i'm fine if you want to leave this as is in this PR :)


module['exports']['CallOptions'] = CallOptions;
module['exports']['MethodDescriptor'] = MethodDescriptor;
module['exports']['GrpcWebClientBase'] = GrpcWebClientBase;
module['exports']['RpcError'] = RpcError;
module['exports']['StatusCode'] = StatusCode;
module['exports']['MethodDescriptor'] = MethodDescriptor;
module['exports']['MethodType'] = MethodType;