Fix status and error callbacks #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stanley-cheung Could you please do a release which includes this fix? |
loyalpartner
pushed a commit
to loyalpartner/grpc-web
that referenced
this pull request
Sep 4, 2020
Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.1 to 2.2.4. **This update includes security fixes.** - [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases) - [Commits](TooTallNate/proxy-agents@2.2.1...2.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced this PR:
cancel()on a stream, don't trigger anerrorcallback for theABORTEDevent. This is for Aborting ClientReadableStream results in error event being fired #544grpc-statusandgrpc-headerare present ingetResponseHeaders()before trying to access them. This is for getStreamingResponseHeader errors when header not in Access-Control-Expose-Headers #574@grpc/grpc-jspackage rather than thegrpcpackage.cancelto be a command in the Echo example. This will callstream.cancel().