Fix code generator bug and add tests #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #837
The bug was caused by #780 - when fixing an issue with a missing dot, a section of the code was inadvertently removed, which handles nested messages.
So the fix is to handle both cases :)
What's challenging is to add tests to make sure both cases won't be broken by new changes to the code generator.
The test case in #837 is reflected in the
test01.proto
introduced by this PR.The test case in #693 is reflected in
test02.proto
andtest03.proto
.The tests
tsc
on them to make sure they compile (using an entry pointclientXX.ts
, which imports these generated protos),