Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSM O11y: Enable Python #91

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

XuanWang-Amos
Copy link
Collaborator

@XuanWang-Amos XuanWang-Amos commented Jun 3, 2024

Ad-hoc run:

Note

@XuanWang-Amos XuanWang-Amos requested review from sergiitk and gnossen June 3, 2024 15:59
@XuanWang-Amos XuanWang-Amos force-pushed the enable_python_csm_o11y_test branch from 74c1a23 to 57e0df3 Compare June 3, 2024 23:18
copybara-service bot pushed a commit to grpc/grpc that referenced this pull request Jun 3, 2024
Passed test run:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/bf34eda3-aa41-47b1-87e8-95b66afedb6e)

Related Interop framework change:
* grpc/psm-interop#91
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes #36790

PiperOrigin-RevId: 639953335
@sergiitk sergiitk changed the title Enable python CSM observability test CSM O11y: Enable Python Jun 5, 2024
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve conflicts with main

tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
@XuanWang-Amos XuanWang-Amos force-pushed the enable_python_csm_o11y_test branch from 1baecae to 9bb4a66 Compare June 5, 2024 21:57
Copy link
Member

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

tests/gamma/csm_observability_test.py Outdated Show resolved Hide resolved
@XuanWang-Amos XuanWang-Amos force-pushed the enable_python_csm_o11y_test branch from 9bb4a66 to 093a5cb Compare June 6, 2024 15:32
@XuanWang-Amos XuanWang-Amos merged commit 1e441a2 into grpc:main Jun 6, 2024
7 checks passed
sergiitk pushed a commit that referenced this pull request Jun 11, 2024
#91, #95, #96, #97 should all be done to the AppNetCsm test as well,
just that the test was merged after the fact.

Next step is to refactor out all the common logic into a Mixin class.
sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request Sep 26, 2024
Passed test run:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/bf34eda3-aa41-47b1-87e8-95b66afedb6e)

Related Interop framework change:
* grpc/psm-interop#91
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#36790

PiperOrigin-RevId: 639953335
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Nov 25, 2024
Passed test run:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/bf34eda3-aa41-47b1-87e8-95b66afedb6e)

Related Interop framework change:
* grpc/psm-interop#91
<!--

If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the appropriate
lang label.

-->

Closes grpc#36790

PiperOrigin-RevId: 639953335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants