copy file modes (permission...) to copied files

[BenjaminDobler]

• adding file mode (permission…) to copied files (related to: Corrupted copy #24)

[ctalkington]

this should be optional, as an option, due the extra FS lookups just to get permissions that not everyone/use case cares about.

[BenjaminDobler]

Makes sense to me. I added the option "copyMode".

[shama]

Thanks for the PR. Could you make this an option instead of using filePair.orig.copyMode? Also just name it mode as I think copyMode is too redundant?

Also since we're adding this option, would it make sense to just also let the mode be set through the option? For example:

var options = this.options({
  mode: false,
});

// ...

if (options.mode !== false) {
  fs.chmodSync(dest, (options.mode === true) ? fs.lstatSync(src).mode : options.mode);
}

[BenjaminDobler]

@shama like this approach as well cause you don`t have to pass the option for every file. Change committed!

[shama]

Thanks!

[unindented]

Last update was 7 months ago. Is there anything stopping project admins from pushing a new version with this option to npm?

[michaellopez]

@shama Are you waiting for #104 to release this?

[vladikoff]

Hey @unindented and @michaellopez backwards compatibility (current and future) is really important to us, so we really need to be careful how we publish this on npm. Grunt core supposed to get this fix but didn't. The fix is postponed to 0.4.3.
You can use the temporary fix that @shama merged 2 months ago by doing:

npm install gruntjs/grunt-contrib-copy --save-dev

If you have time, you can really help us by joining the discussion here: gruntjs/grunt#732 and helping us test this fix. (Also gruntjs/grunt#615, but I think #732 is the one that has a link to the fixed branch)
Thanks for understanding and your help!

[michaellopez]

@vladikoff Thanks for your quick reply. I understand what you're saying. I was unaware of the issues in Grunt core, hence my question. Now that I know I might be able to help there.