Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhantomJS -> Chrome Headless #257

Closed
stdavis opened this issue May 5, 2017 · 0 comments
Closed

PhantomJS -> Chrome Headless #257

stdavis opened this issue May 5, 2017 · 0 comments

Comments

@stdavis
Copy link
Contributor

stdavis commented May 5, 2017

PhantomJS is no longer being maintained. Would the maintainers of this project be open to switching to headless chrome? I'd be open to submitting a PR. Any thoughts/direction?
@stdavis stdavis mentioned this issue May 17, 2018
Merged
4 tasks
vladikoff pushed a commit that referenced this issue May 20, 2018
@stdavis @vladikoff
Switch from PhantomJS to Chrome Headless via Puppeteer (#269)
02e72f3 
Closes #257

This PR tears out PhantomJS (no longer maintained) and replaces it with Chrome Headless via the Puppeteer project. Our office got tired of fighting with PhamtomJS.

Here are the highlights of the changes:

  Removed all references to phantomjs (not quite there yet)
  Upgrade from jshint to eslint (required for the async/await code IIRC)
  Cleaned up a bunch of apparently unused jasmine files
  Upgraded min node version from 0.10.0 to 7.6.0 (required for async/await)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stdavis