-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from PhantomJS to Chrome Headless via Puppeteer #269
Changes from 8 commits
f78c60e
12c60bd
dbb62e0
9ce854d
b4969f2
cf768ef
4c93d0d
b30958b
ddfb86c
9f3cfbb
af9675b
8209e9b
1029d39
0b0a405
65683f0
8dfa262
5d1adb9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "eslint:recommended", | ||
"parserOptions": { | ||
"ecmaVersion": 2017 | ||
}, | ||
"env": { | ||
"browser": true, | ||
"node": true, | ||
"jasmine": true, | ||
"es6": true | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ junit | |
.DS_Store | ||
.grunt | ||
/_SpecRunner.html | ||
.custom |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,10 @@ sudo: false | |
language: node_js | ||
|
||
node_js: | ||
- "4" | ||
- "6" | ||
- "8" | ||
- "9" | ||
|
||
matrix: | ||
fast_finish: true | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# grunt-contrib-jasmine v1.1.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master) | ||
# grunt-contrib-jasmine v1.2.0 [![Build Status: Linux](https://travis-ci.org/gruntjs/grunt-contrib-jasmine.svg?branch=master)](https://travis-ci.org/gruntjs/grunt-contrib-jasmine) [![Build Status: Windows](https://ci.appveyor.com/api/projects/status/5985958by5rhnh31/branch/master?svg=true)](https://ci.appveyor.com/project/gruntjs/grunt-contrib-jasmine/branch/master) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we can just v2 this probably due to major change? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is a major change but it doesn’t break the current api. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'll revert this and let the versioning get handled by the merging folks. |
||
|
||
> Run jasmine specs headlessly through PhantomJS | ||
|
||
|
@@ -358,4 +358,4 @@ grunt.initConfig({ | |
|
||
Task submitted by [Jarrod Overson](http://jarrodoverson.com) | ||
|
||
*This file was generated on Thu Jan 12 2017 13:09:46.* | ||
*This file was generated on Mon May 14 2018 15:35:38.* |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,12 +5,16 @@ version: "{build}" | |
# What combinations to test | ||
environment: | ||
matrix: | ||
- nodejs_version: "6" | ||
- nodejs_version: "4" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same, drop 4 |
||
platform: x64 | ||
- nodejs_version: "4" | ||
platform: x86 | ||
- nodejs_version: "6" | ||
platform: x64 | ||
platform: x86 | ||
- nodejs_version: "8" | ||
platform: x86 | ||
- nodejs_version: "9" | ||
platform: x86 | ||
|
||
install: | ||
- ps: Install-Product node $env:nodejs_version $env:platform | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can probably drop 4, it's EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably drop 6 then also?