Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(doesPathContain): make code more readable and workaround node 5.7.0 issue #1475

Closed
wants to merge 1 commit into from
Closed

fix(doesPathContain): make code more readable and workaround node 5.7.0 issue #1475

wants to merge 1 commit into from

Conversation

shahata
Copy link

@shahata shahata commented Feb 28, 2016

Closes #1469

@shama
Copy link
Member

shama commented Feb 28, 2016

Thanks for the PR but this is a regression in Node that looks like it will be fixed in 5.7.1. I don't think we need to add a workaround for a very specific latest features version of Node.

@shama shama closed this Feb 28, 2016
@shahata
Copy link
Author

shahata commented Feb 28, 2016

I think it is worth merging even if only for readability, previous code was quite hard to understand and not intuitive.

@shama shama mentioned this pull request Feb 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahata @shama