Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the words 'without errors.' after successfully running tasks #986

Merged
merged 1 commit into from Jan 21, 2016
Merged

Remove the words 'without errors.' after successfully running tasks #986

merged 1 commit into from Jan 21, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2013

The presence of the word errors causes automated build result processing to present a false positive for failure. It is commonplace for automation frameworks to look for the presence of the word "error" or "errors." Simply parsing the message in the log output often causes alarm within our organization.

Please consider this change.

The presence of the word errors causes automated build result processing to present a false positive for failure.  It is commonplace for automation frameworks to look for the presence of the word "error" or "errors." Simply parsing the message in the log output often causes alarm within our organization.
@vladikoff
Copy link
Member

Thanks for the report @matthew-ernewein . What framework did you have this issue with? if you don't mind me asking.

@ghost
Copy link
Author

ghost commented Dec 5, 2013

@vladikoff In this particular instance it was a homegrown testing framework produced by our Quality Assurance group. I have observed this pattern in the past at various organizations (scanning for phrases like "exception," "error," and so on. I don't believe that it is the best way to determine if errors are present, and the message in question could pass parse with an appropriate regular expression. However, my opinion (only an opinion) is that a message indicating success shouldn't also bring up the fact that no errors are present. It takes a bit of getting used to the "without errors" message when visually inspecting Grunt output.

@vladikoff
Copy link
Member

Hello again @matthew-ernewein, we looked at this request just now.
Some users already parse the output and look for Done, without errors. Due to this we are going to have to push this until Grunt 0.5

@vladikoff vladikoff mentioned this pull request Jan 25, 2014
15 tasks
@vladikoff vladikoff mentioned this pull request Jun 14, 2014
@gabrielmaldi
Copy link

How about a command line parameter specifying custom success and error messages?

@msikma
Copy link

msikma commented Mar 8, 2015

It would be nice to have greater control over what Grunt outputs and when—I'm not sure if this is already an ongoing process in general. I'd personally prefer it if Grunt outputs nothing if there were no errors.

Maybe a good way to handle this would be to have some kind of output options object inside the Grunt object where you can specify e.g. outputFinalReport to true or false. Then this object can be used for other things, such as specifying what strings to output (and what colors/effects they have), and possibly tied into i18n as well. I'm not sure if any project like this is already underway.

@ShashankaNataraj
Copy link

Instead of a command line parameter, how about defining success and failure messages in a config file like Gruntfile.js itself? If no params are found, the default ones could be used.

@andresventura
Copy link

+1 for this PR - the word 'error' should never be printed in a success message

@dmethvin dmethvin mentioned this pull request Nov 23, 2015
@vladikoff vladikoff modified the milestones: rc1, 0.5.0 Jan 19, 2016
shama added a commit that referenced this pull request Jan 21, 2016
Remove the words 'without errors.' after successfully running tasks
@shama shama merged commit 27a1778 into gruntjs:master Jan 21, 2016
@vladikoff vladikoff removed the ready label Jan 21, 2016
@vladikoff
Copy link
Member

I'm so happy!

@alwinmark
Copy link

What the hell? Seriously guys, you grep for errors to decide if your builds were successful 🙀? Than you deserve to adjust your homegrown build/test infrastructure every time a minor release is out. 💣

See:
https://en.wikipedia.org/wiki/Exit_status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants