-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the words 'without errors.' after successfully running tasks #986
Conversation
The presence of the word errors causes automated build result processing to present a false positive for failure. It is commonplace for automation frameworks to look for the presence of the word "error" or "errors." Simply parsing the message in the log output often causes alarm within our organization.
Thanks for the report @matthew-ernewein . What framework did you have this issue with? if you don't mind me asking. |
@vladikoff In this particular instance it was a homegrown testing framework produced by our Quality Assurance group. I have observed this pattern in the past at various organizations (scanning for phrases like "exception," "error," and so on. I don't believe that it is the best way to determine if errors are present, and the message in question could pass parse with an appropriate regular expression. However, my opinion (only an opinion) is that a message indicating success shouldn't also bring up the fact that no errors are present. It takes a bit of getting used to the "without errors" message when visually inspecting Grunt output. |
Hello again @matthew-ernewein, we looked at this request just now. |
How about a command line parameter specifying custom success and error messages? |
It would be nice to have greater control over what Grunt outputs and when—I'm not sure if this is already an ongoing process in general. I'd personally prefer it if Grunt outputs nothing if there were no errors. Maybe a good way to handle this would be to have some kind of output options object inside the Grunt object where you can specify e.g. outputFinalReport to true or false. Then this object can be used for other things, such as specifying what strings to output (and what colors/effects they have), and possibly tied into i18n as well. I'm not sure if any project like this is already underway. |
Instead of a command line parameter, how about defining success and failure messages in a config file like Gruntfile.js itself? If no params are found, the default ones could be used. |
+1 for this PR - the word 'error' should never be printed in a success message |
Remove the words 'without errors.' after successfully running tasks
I'm so happy! |
What the hell? Seriously guys, you grep for errors to decide if your builds were successful 🙀? Than you deserve to adjust your homegrown build/test infrastructure every time a minor release is out. 💣 |
The presence of the word errors causes automated build result processing to present a false positive for failure. It is commonplace for automation frameworks to look for the presence of the word "error" or "errors." Simply parsing the message in the log output often causes alarm within our organization.
Please consider this change.