Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-containerregistry #1414

Closed
aktasfatih opened this issue Jun 24, 2024 · 0 comments · Fixed by #1469
Closed

Update go-containerregistry #1414

aktasfatih opened this issue Jun 24, 2024 · 0 comments · Fixed by #1469
Assignees
@denis256
Labels
bug Something isn't working terratest

Comments

@aktasfatih
Copy link

aktasfatih commented Jun 24, 2024 •
edited
Loading

Describe the bug
An old version of go-containerregistry@v0.6.0 is being used in this pkg, causing dependency issues when github.com/google/go-containerregistry@v0.19.2 is used.

The conflict is at

terratest@v0.46.15/modules/gcp/gcr.go:23:17: not enough arguments in call to gcrgoogle.NewEnvAuthentication

Expected behavior
Use of terratest@v0.46.15 doesn't cause issues with go-containerregistry@v0.19.2

Versions

  • Terratest version: v0.46.15
@aktasfatih aktasfatih added the bug Something isn't working label Jun 24, 2024
@ZachGoldberg ZachGoldberg added the terratest label Jun 25, 2024 — with Linear
wakeful added a commit to wakeful/terratest that referenced this issue Nov 12, 2024
@wakeful
update go.mod pkg for GCP, DNS and few other shared pkg. fix gruntwor…
a4aff31 
…k-io#1414
@wakeful wakeful mentioned this issue Nov 12, 2024
Merged
5 tasks
wakeful added a commit to wakeful/terratest that referenced this issue Nov 15, 2024
@wakeful
update go.mod pkg for GCP, DNS and few other shared pkg. fix gruntwor…
d3a0c7b 
…k-io#1414
yhakbar pushed a commit to wakeful/terratest that referenced this issue Nov 19, 2024
@wakeful @yhakbar
update go.mod pkg for GCP, DNS and few other shared pkg. fix gruntwor…
8edfff7 
…k-io#1414
yhakbar added a commit that referenced this issue Nov 19, 2024
@yhakbar
Merge pull request #1469 from wakeful/update-go-mod-dep
33c3c13 
update go.mod pkg for GCP, DNS and few other shared pkg. fix #1414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@denis256 denis256

Labels
bug Something isn't working terratest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update go.mod pkg for GCP, DNS and few other shared pkg. fix #1414 wakeful/terratest
3 participants
@ZachGoldberg @denis256 @aktasfatih