Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Go to 1.18 #1196

Merged
merged 2 commits into from
Nov 9, 2022
Merged

Bump Go to 1.18 #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c81413f
Bump Go to 1.18
infraredgirl Nov 7, 2022
909e95b
Fix k8s tests
infraredgirl Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ env: &env
PACKER_VERSION: 1.7.4
TERRAGRUNT_VERSION: v0.36.0
OPA_VERSION: v0.33.1
GO_VERSION: 1.17
GO_VERSION: 1.18
GO111MODULE: auto
K8S_VERSION: v1.18.20 # Same as EKS
MINIKUBE_VERSION: v1.22.0
Expand Down
2 changes: 1 addition & 1 deletion docs/_docs/01_getting-started/quick-start.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ custom_js:

Terratest uses the Go testing framework. To use Terratest, you need to install:

- [Go](https://golang.org/) (requires version >=1.17)
- [Go](https://golang.org/) (requires version >=1.18)

## Setting up your project

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/gruntwork-io/terratest

go 1.17
go 1.18

require (
cloud.google.com/go v0.83.0
Expand Down
3 changes: 0 additions & 3 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4/go.mod h1:ybxpYRF
github.com/alexflint/go-filemutex v0.0.0-20171022225611-72bdc8eae2ae/go.mod h1:CgnQgUtFrFz9mxFNtED3jI5tLDjKlOM+oUF/sTk6ps0=
github.com/antihax/optional v1.0.0/go.mod h1:uupD/76wgC+ih3iEmQUL+0Ugr19nfwCT1kdvxnR2qWY=
github.com/apparentlymart/go-dump v0.0.0-20180507223929-23540a00eaa3/go.mod h1:oL81AME2rN47vu18xqj1S1jPIPuN7afo62yKTNn3XMM=
github.com/apparentlymart/go-textseg v1.0.0 h1:rRmlIsPEEhUTIKQb7T++Nz/A5Q6C9IuX2wFoYVvnCs0=
github.com/apparentlymart/go-textseg v1.0.0/go.mod h1:z96Txxhf3xSFMPmb5X/1W05FF/Nj9VFpLOpjS5yuumk=
github.com/apparentlymart/go-textseg/v13 v13.0.0 h1:Y+KvPE1NYz0xl601PVImeQfFyEy6iT90AvPUL1NNfNw=
github.com/apparentlymart/go-textseg/v13 v13.0.0/go.mod h1:ZK2fH7c4NqDTLtiYLvIkEghdlcqw7yxLeM89kiTRPUo=
Expand Down Expand Up @@ -503,7 +502,6 @@ github.com/hashicorp/go-version v1.3.0/go.mod h1:fltr4n8CU8Ke44wwGCBoEymUuxUHl09
github.com/hashicorp/go.net v0.0.1/go.mod h1:hjKkEWcCURg++eb33jQU7oqQcI9XDCnUzHA0oac0k90=
github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8=
github.com/hashicorp/hcl v1.0.0 h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=
github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ=
github.com/hashicorp/hcl/v2 v2.9.1 h1:eOy4gREY0/ZQHNItlfuEZqtcQbXIxzojlP301hDpnac=
github.com/hashicorp/hcl/v2 v2.9.1/go.mod h1:FwWsfWEjyV/CMj8s/gqAuiviY72rJ1/oayI9WftqcKg=
Expand Down Expand Up @@ -1308,7 +1306,6 @@ gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b h1:h8qDotaEPuJATrMmW04NCwg7v22aHH28wwpauUhK9Oo=
gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
gotest.tools v2.2.0+incompatible h1:VsBPFP1AI068pPrMxtb/S8Zkgf9xEmTLJjfM+P5UIEo=
gotest.tools v2.2.0+incompatible/go.mod h1:DsYFclhRJ6vuDpmuTbkuFWG+y2sxOXAzmJt81HFBacw=
gotest.tools/v3 v3.0.2/go.mod h1:3SzNCllyD9/Y+b5r9JIKQ474KzkZyqLqEfYqMsX94Bk=
gotest.tools/v3 v3.0.3 h1:4AuOwCGf4lLR9u3YOe2awrHygurzhO/HeQ6laiA6Sx0=
Expand Down
2 changes: 2 additions & 0 deletions modules/k8s/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ preferences: {}
users:
- name: minikube
user:
as-user-extra: null
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason, without this change, five k8s tests fail. I don't really understand why, but I've confirmed that they fail when run with go 1.18 but pass with go 1.17. Very strange.

client-certificate: /home/terratest/.minikube/client.crt
client-key: /home/terratest/.minikube/client.key
`
Expand Down Expand Up @@ -264,6 +265,7 @@ preferences: {}
users:
- name: minikube
user:
as-user-extra: null
client-certificate: /home/terratest/.minikube/client.crt
client-key: /home/terratest/.minikube/client.key
`
2 changes: 1 addition & 1 deletion modules/logger/parser/fixtures/basic_example_expected/report.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<testsuites>
<testsuite tests="52" failures="0" time="1.019" name="github.com/gruntwork-io/terratest/modules/logger/parser">
<properties>
<property name="go.version" value="go1.17"></property>
<property name="go.version" value="go1.18"></property>
</properties>
<testcase classname="parser" name="TestStackPush" time="0.000"></testcase>
<testcase classname="parser" name="TestStackPop" time="0.000"></testcase>
Expand Down
2 changes: 1 addition & 1 deletion modules/logger/parser/fixtures/failing_example_expected/report.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<testsuites>
<testsuite tests="55" failures="3" time="1.020" name="github.com/gruntwork-io/terratest/modules/logger/parser">
<properties>
<property name="go.version" value="go1.17"></property>
<property name="go.version" value="go1.18"></property>
</properties>
<testcase classname="parser" name="TestStackPush" time="0.000"></testcase>
<testcase classname="parser" name="TestStackPop" time="0.000"></testcase>
Expand Down
2 changes: 1 addition & 1 deletion modules/logger/parser/fixtures/new_go_failing_example_expected/report.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<testsuites>
<testsuite tests="3" failures="1" time="1.589" name="github.com/gruntwork-io/terratest/modules/logger/parser">
<properties>
<property name="go.version" value="go1.17"></property>
<property name="go.version" value="go1.18"></property>
</properties>
<testcase classname="parser" name="TestIntegrationBasicExample" time="0.000">
<failure message="Failed" type=""> integration_test.go:57: </failure>
Expand Down
2 changes: 1 addition & 1 deletion modules/logger/parser/fixtures/panic_example_expected/report.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<testsuites>
<testsuite tests="52" failures="4" time="0.020" name="github.com/gruntwork-io/terratest/modules/logger/parser">
<properties>
<property name="go.version" value="go1.17"></property>
<property name="go.version" value="go1.18"></property>
</properties>
<testcase classname="parser" name="TestStackPush" time="0.000"></testcase>
<testcase classname="parser" name="TestStackPop" time="0.000"></testcase>
Expand Down