Fetch the default VPC instead of a random one #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not be using VPCs at random. Our tests create and destroy VPCs all the time, so it's possible that one test will accidentally try to use a VPC that another test is trying to destroy. This changes terratest to return the default VPC instead of a random one.
| import ( | ||
| "github.com/aws/aws-sdk-go/service/ec2" | ||
| "github.com/aws/aws-sdk-go/aws/session" | ||
| "github.com/aws/aws-sdk-go/aws" | ||
| "errors" | ||
| "github.com/gruntwork-io/terratest/util" | ||
| "strconv" | ||
| ) |
There was a problem hiding this comment.
import order. You may have commented on this in a separate PR.
|
Looks good, and will merge. One thought is that it is possible to delete the default VPC, but I don't think any of them are deleted in the PhxDevOps account. Still, something to be aware of. It looks like error handling will make this apparent if it comes up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not be using VPCs at random. Our tests create and destroy
VPCs all the time, so it's possible that one test will accidentally try
to use a VPC that another test is trying to destroy. This changes
terratest to return the default VPC instead of a random one.