Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fail on specific warning messages #1426

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Conversation

james03160927
Copy link
Contributor

Description

Fixes #436.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 requested a review from denis256 as a code owner July 26, 2024 02:25
@james03160927 james03160927 changed the title fail on warning Allow to fail on specific warning messages Jul 26, 2024
modules/terraform/cmd.go Outdated Show resolved Hide resolved
@james03160927
Copy link
Contributor Author

Should be good for another round of review @denis256

@james03160927 james03160927 merged commit 9ffe143 into master Aug 5, 2024
2 of 3 checks passed
@james03160927 james03160927 deleted the fail-on-warning branch August 5, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect and report warnings
2 participants