Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CircleCi Helm Test #1429

Merged
merged 1 commit into from
Aug 5, 2024
Merged

Fix CircleCi Helm Test #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion examples/terraform-aws-lambda-example/src/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
The lambda executable `handler` was built using

``` shell
go build bootstrap.go
go get github.com/aws/aws-lambda-go/lambda
GOOS=linux GOARCH=amd64 go build -tags lambda.norpc -o bootstrap .
```
Binary file modified examples/terraform-aws-lambda-example/src/bootstrap
View file
Open in desktop
Binary file not shown.
9 changes: 5 additions & 4 deletions modules/retry/retry_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,19 +115,20 @@ func TestDoWithTimeout(t *testing.T) {
func TestDoInBackgroundUntilStopped(t *testing.T) {
t.Parallel()

sleepBetweenRetries := 5 * time.Second
sleepBetweenRetries := 2 * time.Second
waitStop := sleepBetweenRetries*2 + sleepBetweenRetries/2
counter := 0

stop := DoInBackgroundUntilStopped(t, t.Name(), sleepBetweenRetries, func() {
counter++
t.Log(time.Now(), counter)
})

time.Sleep(sleepBetweenRetries * 3)
time.Sleep(waitStop)
stop.Done()

assert.Equal(t, 3, counter)

time.Sleep(sleepBetweenRetries * 3)
time.Sleep(waitStop)
assert.Equal(t, 3, counter)
}

Expand Down
2 changes: 1 addition & 1 deletion test/helm_keda_remote_example_template_snapshot_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,5 +173,5 @@ func TestHelmKedaRemoteExampleTemplateRenderedPackageDiff(t *testing.T) {
output := helm.RenderRemoteTemplate(t, options, "https://kedacore.github.io/charts", releaseName, []string{})

// run the diff and assert the number of diffs matches the number of diffs in the snapshot
require.Equal(t, 18, helm.DiffAgainstSnapshot(t, options, output, releaseName))
require.Equal(t, 24, helm.DiffAgainstSnapshot(t, options, output, releaseName))
}