Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1363 build lambda bin from src instead using a blob + bump ext pkg. #1470

Merged

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 13, 2024

Description

Fixes #1363 build lambda binary from source instead using a blob + bump ext pkg.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Migration Guide

n/a

@wakeful wakeful requested a review from denis256 as a code owner November 13, 2024 10:07
@wakeful wakeful force-pushed the bump-aws-lambda-pkg-rm-bin-from-dvcs branch from 9ff9cd1 to 0a3656a Compare November 19, 2024 17:51
@yhakbar
Copy link
Contributor

yhakbar commented Nov 19, 2024

Tested this test locally, and it works. CI needs some cleanup to work correctly, so I'm not going to hold up the merge before CI passes.

@yhakbar yhakbar merged commit ce008dc into gruntwork-io:master Nov 19, 2024
2 of 3 checks passed
@wakeful wakeful deleted the bump-aws-lambda-pkg-rm-bin-from-dvcs branch November 19, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why binary included in example AWS lambda?
2 participants