Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add platform parameter to docker run command. fix #1310 #1471

Merged
merged 1 commit into from
Dec 4, 2024
Merged

add platform parameter to docker run command. fix #1310 #1471

merged 1 commit into from
Dec 4, 2024

Conversation

wakeful
Copy link
Contributor

@wakeful wakeful commented Nov 13, 2024

Description

Fixes #1310 add platform parameter to docker run command

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added platform parameter to docker run command

Migration Guide

n/a

@wakeful wakeful requested a review from denis256 as a code owner November 13, 2024 16:36
james03160927
james03160927 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change LGTM. Thanks for the contribution. Waiting for the test results.

@james03160927
Copy link
Contributor

I see a test failure. Can this be related to your change?

TestTerraformPackerExample 2024-11-18T23:58:14Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:14Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:14Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:19Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:19Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:19Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:24Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:24Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:25Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:30Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:30Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:30Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:35Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:35Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:35Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:40Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:40Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:40Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:45Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:45Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:45Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:50Z retry.go:91: HTTP GET to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:50Z http_helper.go:58: Making an HTTP GET call to URL http://3.147.2.74:8080
TestTerraformPackerExample 2024-11-18T23:58:50Z retry.go:103: HTTP GET to URL http://3.147.2.74:8080 returned an error: Get "http://3.147.2.74:8080": dial tcp 3.147.2.74:8080: connect: connection refused. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:58:55Z test_structure.go:29: The 'SKIP_logs' environment variable is not set, so executing stage 'logs'.
TestTerraformPackerExample 2024-11-18T23:58:55Z save_test_data.go:228: Loading test data from ../examples/terraform-packer-example/.test-data/awsRegion.json
TestTerraformPackerExample 2024-11-18T23:58:55Z save_test_data.go:228: Loading test data from ../examples/terraform-packer-example/.test-data/TerraformOptions.json
TestTerraformPackerExample 2024-11-18T23:58:55Z retry.go:91: terraform [output -no-color -json instance_id]
TestTerraformPackerExample 2024-11-18T23:58:55Z logger.go:66: Running command terraform with args [output -no-color -json instance_id]
TestTerraformPackerExample 2024-11-18T23:58:56Z logger.go:66: "i-0f3aeefa3c34dba1f"
TestTerraformPackerExample 2024-11-18T23:58:56Z ec2-syslog.go:36: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:58:56Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:58:57Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:02Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:02Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:07Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:07Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:12Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:12Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:17Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:17Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:22Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:23Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:28Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:28Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:33Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:33Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:38Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:38Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:43Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:43Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:48Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:48Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:53Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:54Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-18T23:59:59Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-18T23:59:59Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:04Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:04Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:09Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:09Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:14Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:14Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:19Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:19Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:24Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:25Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:30Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:30Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:35Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:35Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:40Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:40Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:45Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:45Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:50Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:51Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:00:56Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:00:56Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:01Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:01Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:06Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:06Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:11Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:11Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:16Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:17Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:22Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:22Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:27Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:27Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:32Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:32Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:37Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:37Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:42Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:43Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:48Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:48Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:53Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:53Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:01:58Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:01:58Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:03Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:03Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:08Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:09Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:14Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:14Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:19Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:19Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:24Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:24Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:29Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:29Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:34Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:35Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:40Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:40Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:45Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:45Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:50Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:50Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:02:55Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:02:55Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:03:00Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:03:01Z retry.go:103: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2 returned an error: Syslog is not yet available for instance i-0f3aeefa3c34dba1f in us-east-2. Sleeping for 5s and will try again.
TestTerraformPackerExample 2024-11-19T00:03:06Z retry.go:91: Fetching syslog for Instance i-0f3aeefa3c34dba1f in us-east-2
TestTerraformPackerExample 2024-11-19T00:03:06Z terraform_packer_example_test.go:168: Most recent syslog for Instance i-0f3aeefa3c34dba1f:

@wakeful
Copy link
Contributor Author

wakeful commented Nov 20, 2024

Let me check - the weird part is that the same test is failing in the SDKv2 bump branch. I'll take a look today.

@wakeful
Copy link
Contributor Author

wakeful commented Nov 20, 2024

It seems the above failing test was related to a missing HTTP server. This has been fixed as part of #1451

@james03160927
Copy link
Contributor

Let's rebase the code with the recent change and I'll trigger the test pipeline once again to see if there are any major concern with the change.

@wakeful wakeful force-pushed the add-platform-argument-to-docker-module branch from 628e9ec to 2bfafa9 Compare December 2, 2024 14:18
@wakeful
Copy link
Contributor Author

wakeful commented Dec 2, 2024

rebase done

@wakeful wakeful requested a review from james03160927 December 2, 2024 14:18
james03160927
james03160927 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@james03160927 james03160927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Passing all the relevant tests.

@james03160927 james03160927 merged commit dcdeba5 into gruntwork-io:master Dec 4, 2024
2 checks passed
@wakeful wakeful deleted the add-platform-argument-to-docker-module branch December 4, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james03160927 james03160927 james03160927 approved these changes

@denis256 denis256 Awaiting requested review from denis256

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

packer_hello_world_example_test.go fails on Apple Silicon
2 participants
@wakeful @james03160927