-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Renaming master
to main
wherever it's referenced
#1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this change is breaking some unit tests.
- TestGitRefChecks/GetCurrentBranchNameReturnsBranchName
- TestGitRefChecks/GetCurrentBranchNameReturnsBranchName
Other failing tests don't seem to be related.
It seemed to me like the root cause of those failures was in itself the change in branch name. Is that assessment wrong? |
If I'm not being clear, this line: Won't work right now because the |
Ah you are right. LGTM then! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Fixes #1473.
Right before merging this, we'll need to explicitly perform the rename of the default branch from
master
tomain
in the GitHub repository settings.This will ensure that all PRs get moved over to the new branch name, etc.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Updated default branch from
master
tomain
.Migration Guide
If you have a locally cloned copy of Terratest, make sure to delete the
master
branch and check out themain
branch.