Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not log ec2 keypair #1480

Merged
merged 1 commit into from
Dec 7, 2024
Merged

do not log ec2 keypair #1480

merged 1 commit into from
Dec 7, 2024

Conversation

james03160927
Copy link
Contributor

Description

Fixes #1135

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

@james03160927 james03160927 self-assigned this Dec 6, 2024
@james03160927 james03160927 merged commit a990ca7 into main Dec 7, 2024
2 of 3 checks passed
@james03160927 james03160927 deleted the nolog-ec2-keypair branch December 7, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis256 denis256 denis256 approved these changes

Assignees

@james03160927 james03160927

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

teststructure.SaveEc2KeyPair exposes the private key in the log output
2 participants
@james03160927 @denis256