Add SkipStageEnvVarSet method. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brikis98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Update our SSH code so it properly times out connections. For some reason, the timeout built into Go’s SSH library doesn’t work, and as a result, our tests that use SSH (e.g., module-server with persistent-ebs-volume) sometimes hang for a very long time or forever.Update: it turns out the SSH timeouts do work and in reality, the persistent-ebs-volume test was successfully connecting over SSH, but then callingsleep 300! I've removed this change, but if we ever need it in the future, it's in this PR.Add a
SkipStageEnvVarSetto make it easier to distinguish between local dev and CI server.