-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding Azure Container Registry module #592
Merged
yorinasub17
merged 10 commits into
gruntwork-io:master
from
polatengin:feature/azure-acr-module
Aug 4, 2021
Merged
feat: adding Azure Container Registry module #592
yorinasub17
merged 10 commits into
gruntwork-io:master
from
polatengin:feature/azure-acr-module
Aug 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polatengin
changed the title
adding Azure Container Registry module
feat: adding Azure Container Registry module
Sep 1, 2020
Hi @yorinasub17 , please take a look when you get a chance, Here is a link to the passed CI |
yorinasub17
approved these changes
Aug 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm going to kick off a sanity check build and if it passes through the precommit hooks, we can merge this in!
Ok the precommit hook passed, so we can merge this in! |
This was referenced Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for adding Azure Container Registry module to the Terratest.
With this module, it can be possible to test Azure Container Registry resources on Terraform scripts.