Run postInit when CBA_SettingsInitialized has been triggered #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusselwurm
approved these changes
Jul 25, 2022
Init code, when it depends on CBA settings, now executes when the CBA_SettingsInitialized event is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents race conditions whereby the
grad_civs_main_enabledflag could be initialized after the scripts are executed.Tested:
Dedicated server test scenarios:
In both scenarios, where the dedicated server and headless client both owned the civilian objects, civilians did spawn successfully and there were no issues with evaluating the value of
grad_civs_main_enabled.I haven't tested bug #125 but this change may also resolve that problem.