Post-release bugfixes #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap the if statement to allow the random function to evaluate the day/night times.
to broadcast to headless clients.
Fusselwurm
reviewed
Aug 3, 2022
| @@ -5,7 +5,7 @@ | |||
| private _isSleepingTime = _this call EFUNC(activities,isSleepingTime); | |||
|
|
|||
| private _house = _this getVariable ["grad_civs_home", objNull]; | |||
| _this setVariable [QGVAR(housework_time), random if (_isSleepingTime) then {GVAR(houseworkTimesNight)} else {GVAR(houseworkTimesDay)}]; | |||
There was a problem hiding this comment.
you really like that syntax, do you.
Seriously though, I was sure I had residents in my test scenario, it should've failed right away.
Fusselwurm
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the housework_enter state whereby the
randomevaluation would fail due to the if statement not being wrapped. Also changed to use the alternative syntax for if-else values.Updated the
setCiviliansandsetVehiclesfunctions to update CBA at a server level while storing the value. I've found that using"mission"doesn't broadcast the value to headless clients that are JIP.