Add modifiable clock rate for spawn attempts #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusselwurm
reviewed
Feb 19, 2023
| @@ -125,3 +125,14 @@ private _settingsGroup = ["GRAD Civilians", "2) lifecycle - performance & spawni | |||
| }, | |||
| false | |||
| ] call CBA_fnc_addSetting; | |||
|
|
|||
| [ | |||
| QGVAR(clockrate), | |||
There was a problem hiding this comment.
semantic nitpick: a rate is a count over time (like, X per second) whereas this setting here is a time value (delay or timeout in seconds).
Either:
- we rename this var accordingly (maybe "spawnDelay")?,
Or:
- change description to "spawn attempts per second" and
- a value of
1 / GVAR(clockrate)in the CBA_fnc_addPerFrameHandler call below
There was a problem hiding this comment.
I'll just go ahead and do the latter one, I like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.