Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added shebang to explicitly run bin with node #44

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Added shebang to explicitly run bin with node #44

merged 1 commit into from
Dec 11, 2020

Conversation

idmadj
Copy link
Contributor

@idmadj idmadj commented Dec 10, 2020

On Windows the CLI fails as it is executed with Windows Script Host instead of node. This happens because cli.js is missing the shebang. This change allows the CLI to function on Windows.

From npm's docs:

Please make sure that your file(s) referenced in bin starts with #!/usr/bin/env node, otherwise the scripts are started without the node executable!

blakek
blakek approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@blakek blakek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that. We're changing our build processes, and Windows was just overlooked.

@blakek blakek merged commit 99a3819 into gsandf:master Dec 11, 2020
@blakek
Copy link
Contributor

blakek commented Dec 11, 2020

This was released with v4.0.1

@idmadj
Copy link
Contributor Author

idmadj commented Dec 11, 2020

Thanks for the quick publish!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakek blakek blakek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idmadj @blakek