Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links #2466

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update links #2466

merged 1 commit into from
Nov 14, 2024

Conversation

leoheitmannruiz
Copy link
Contributor

The fdroid.app: thingies don't seem to render correctly https://f-droid.org/packages/net.gsantner.markor/

Also, it seems Markor is the only app in F-Droid that uses them:

$ grep "fdroid.app:" index-v2.json | wc -l
       1

Perhaps it makes sense to update the links here and deprecate the fdroid.app: thingies over at F-Droid. I'll ask them.

@gsantner
Copy link
Owner

gsantner commented Oct 31, 2024

Hello, Does the new link open thr entry in F-Droid app if you have it installed? Thats what that prefix is about

@leoheitmannruiz
Copy link
Contributor Author

Oh, huh.

No. But currently they don't, either.

@leoheitmannruiz
Copy link
Contributor Author

Internally, by F-Droid, the fdroid.app: links are converted to "normal" ones anyway: https://gitlab.com/fdroid/jekyll-fdroid/-/blob/f18e1ccf4119264f6ca045800fcaaecc14e6d71d/lib/fdroid/Package.rb#L170

@gsantner
Copy link
Owner

gsantner commented Oct 31, 2024

it would just be good to use links that lead to Markor entry inside app.

As far I see www.f-droid.org, but not without www is registered.

@leoheitmannruiz
Copy link
Contributor Author

leoheitmannruiz commented Oct 31, 2024

it would just be good to use links that lead to Markor entry inside app.

I don't know if it's possible. Does it work on your end? Regardless, I doubt it's going to be with fdroid.app: links.

As far I see www.f-droid.org, but not without www is registered.

Where do you see this?

@gsantner
Copy link
Owner

Screenshot-20241031-150524-Einstellungen.png

@leoheitmannruiz
Copy link
Contributor Author

Oh sorry. I use F-Droid Basic and apparently it doesn't handle f-droid.org links, so I was little confused. But I installed the normal F-Droid client now and indeed it opens the links! So this PR should be good to go!

@leoheitmannruiz
Copy link
Contributor Author

Nice! Anything I have to do here?

@gsantner gsantner merged commit aab47c7 into gsantner:master Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants