Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters in crazyflie2.xacro #56

Closed
SeaingAnt opened this issue Jul 19, 2020 · 11 comments
Closed

Parameters in crazyflie2.xacro #56

SeaingAnt opened this issue Jul 19, 2020 · 11 comments
Assignees
Labels
bug Something isn't working type: enhancement New feature or request type: question Further information is requested

Comments

@SeaingAnt
Copy link

Looking at the parameters in the file crazyflie2.xacro I noticed that the drag coefficient is the same of the Iris drone which is huger that the crazyflie2. is the parameter correct? In addition also the other parameters are significantly different from those in the Forster

@gsilano gsilano self-assigned this Jul 20, 2020
@gsilano gsilano added the type: question Further information is requested label Jul 20, 2020
@gsilano
Copy link
Owner

gsilano commented Jul 20, 2020

The parameter values of the Crazyflie have been taken from this repository by the same research group of

W. Honig and N. Ayanian, “Flying Multiple UAVs using ROS,” in ¨ Robot Operating System (ROS): The Complete Reference (Volume 2), A. Koubaa, Ed. Springer International Publishing, 2017, pp. 83–118.

For more details, see the reference book chapter.

@SeaingAnt
Copy link
Author

Yeah I have already checked the papers but I found strange that the drag is so high since it is equal to the IRIS

@gsilano
Copy link
Owner

gsilano commented Jul 20, 2020

Yes, you are right. Probably such a value is not fair but, first, it would be of interest to understand how much this value can influence the system dynamics (take a look at the Gazebo plugins) and then if someone already addressed its estimation. If you could investigate it, it would be awesome.

@SeaingAnt
Copy link
Author

SeaingAnt commented Jul 20, 2020

Ok I have already done some experiments for making flip where the drag take much more influence and I think that a proper value it will be 1.066428e-06 according to Forster. Indeed it is used here. I think that with this value the motion should be better also for standard planar motion

@gsilano
Copy link
Owner

gsilano commented Jul 20, 2020

Okay, thanks! I will test it as soon as I have time and let you know if this somehow affects the existing control algorithms. So, I will integrate the new value into the repository.

@gsilano gsilano added the bug Something isn't working label Jul 20, 2020
@SeaingAnt
Copy link
Author

SeaingAnt commented Jul 20, 2020

Just to be clear maybe It's worth also to update the other values,also according to the Forster, as follow:

 <!-- Forster's -->
  <xacro:property name="motor_constant" value="1.71465181e-08" /> <!-- [kg m/s^2] -->
  <xacro:property name="moment_constant" value="0.004459273" /> <!-- [m] -->
  <xacro:property name="time_constant_up" value="0.0125" /> <!-- [s] -->
  <xacro:property name="time_constant_down" value="0.025" /> <!-- [s] -->
  <xacro:property name="max_rot_velocity" value="3052" /> <!-- [rad/s] -->
  <xacro:property name="rotor_drag_coefficient" value="1.066428e-06" />
  <xacro:property name="rolling_moment_coefficient" value="0" /> 

@gsilano
Copy link
Owner

gsilano commented Jul 20, 2020

Just to simplify the check process, could you also indicate the pages where you found these values?

@SeaingAnt
Copy link
Author

sure, in the overview result page 57

@gsilano
Copy link
Owner

gsilano commented Aug 15, 2020

Hi @Tonirayn!! Sorry if I did not reply to you, but this very is very full of work for me. I will manage to test your suggestions as soon as possible.

gsilano added a commit that referenced this issue Aug 22, 2020
gsilano added a commit that referenced this issue Aug 22, 2020
@gsilano gsilano added the type: enhancement New feature or request label Aug 22, 2020
gsilano added a commit that referenced this issue Aug 22, 2020
@gsilano
Copy link
Owner

gsilano commented Aug 22, 2020

Eventually, I decided to put the file in the repository (see the CHANGELOG file for more details). Right now, I don't have time to look at the plots, controller performance, and check everything with an identification process. However, I thought it was useful to have such a file as an option. Thanks for your help. Your contribution is now part of CrazyS and your name is on the contributor list :-)

@gsilano gsilano closed this as completed Aug 22, 2020
@SeaingAnt
Copy link
Author

ok thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working type: enhancement New feature or request type: question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants