-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4.1.0 Release #125
4.1.0 Release #125
Conversation
* switch name to config_user.yaml * #61 more switchs
* first pass * edit readme * adding test
* #60 provenance.py mockup * template#60 formatting * #60 add pretty comments * #60 add release mechanism * template#60 respond to pr * template#60 release PR * gslab-econ/template#60 fix bug * #60 respond to PR
* #60 provenance.py mockup * template#60 formatting * #60 add pretty comments * #60 add release mechanism * template#60 respond to pr * template#60 release PR * gslab-econ/template#60 fix bug * #60 respond to PR * gslab-econ/template#60 add non-default sig * gslab-econ/template#60 add external provenance option for release * gslab-econ/template#60 pr * gslab-econ/template#60 fix syntax
… args (#124) * Allow version and readme args in function call instead of sysagrv, update docs * respond to PR
* #128 binding file limit on directory walk * #131 purge provenance * #131 first pass dir recording system * #131 an SCons -> a SCons * #131 change default log location * #131 better naming, load into __init__, better prereq check * #131 change default name for log * #132 #131 change default log name * #132 #131 gslab-econ/template#87 new log headding * #132 #131 better path checks, fix walk-break rule, new path names * #132 #131 fix heading creation of heading with hash
gslab_scons/misc.py
Outdated
@@ -11,39 +11,42 @@ | |||
import _exception_classes | |||
from size_warning import issue_size_warnings | |||
|
|||
def scons_debrief(target, env): | |||
'''Execute functions after SCons has built all targets''' | |||
def scons_debrief(args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduce backward incompatibility, since the user has to modify SConstruct. @Shun-Yang I don't have a great grasp on this function and you were the last one to touch it, can you add a quick fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change args['log']
back into the function argument as log = 'state_of_repo.log'
but the reason we moved it is that this looks more compact and natural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a discussion in the lab just now. Our solution is to provide a user-advisory that you cannot pass env
and log
to the function any longer and have to pass args
, at which point we point to the current SConstruct in template
. So we're fine with both 1) backward incompatibility and 2) coupled gslab_python/template for this particular problem.
gslab_python 4.1.0 Release NotesFeatures
Misc
|
* change log exclusion syntax to proune * #138 respond to pr
* gslab-econ/template#88 recursive fun to flatten dicts * #88 PR, don't clobber repeated keys * #88 cleaner string manipulation in flatten_dict
* #140 remove superfluous assett upload * #140 swap order of git and scons check; note behavior in readme * #140 format readme * #141 #140 split up up_to_date, raise error if not up-to-date * #141 #140 put elif after if * #141 #140 output -> log * #141 #140 add function to determine if scons is a dry run * #140 try some logging stuff * #141 #140 loggers get own files, toggle on scons dry-run
) * #144 gslab-econ/template#96 working versions of clean builders * #144 fix recursive cases when checking vers and multiple cuaght exception * #144 small adjustments to anything builder * #145 #144 switch order of args in builders * #145 #144 cleaner access to default stata executable * #145 #144 docstrings in prereq checks * #145 #144 unscramble more target/source args in the builders
@stanfordquan, I think this is ready to go. Do you want to make the pull? |
notes to follow