Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.0 Release #125

Merged
merged 36 commits into from
Mar 3, 2018
Merged

4.1.0 Release #125

merged 36 commits into from
Mar 3, 2018

Conversation

qlquanle
Copy link

@qlquanle qlquanle commented Sep 5, 2017

notes to follow

Quan and others added 26 commits August 22, 2017 14:51
…lder (#104)

* #92 rm config checking of stata exec, unless stata packages are checked

* #92 edit the messages
* switch name to config_user.yaml

* #61 more switchs
* #96 add latex builder

* #96 write test for latex builder

* #96 change to 4.0.2

* #96 small edit

* #96 delete log files

* #96 add nonstop option in latex builde
* #93 first pass

* #93 second pass

* #93 add carriage return
* #95 first pass

* #95 second pass after testing

* fix PR

* small edits
* #108 update test_build_stata

* #108 fix test_configuration_tests

* #108 fix test_log

* #108 fix test_build_r

* #108 change build_r and tests

* #108 modify test_build_r

* #108 fix some checks after adding check_targets

* #108 comment out target check in build_tables
* #97 write anything builder

* #97 change log_file to log_ext mechanism

* #97 new version, builder generator

* #97 add pretty comments

* #97 fix comment indent

* #97 respond to PR

* #97 warning edits
* #94 allow folders to be exluded from search

* #94 add argument to upper level function

* #94 fix syntax
* LB Edits for latex tablefill

* #102 small edits and re-run tests

* #102 update python and re-run

* #102 update tests for tablefill latex

* #102 edit gitignore
* first pass

* edit readme

* adding test
* #60 provenance.py mockup

* template#60 formatting

* #60 add pretty comments

* #60 add release mechanism

* template#60 respond to pr

* template#60 release PR

* gslab-econ/template#60 fix bug

* #60 respond to PR
* #60 provenance.py mockup

* template#60 formatting

* #60 add pretty comments

* #60 add release mechanism

* template#60 respond to pr

* template#60 release PR

* gslab-econ/template#60 fix bug

* #60 respond to PR

* gslab-econ/template#60 add non-default sig

* gslab-econ/template#60 add external provenance option for release

* gslab-econ/template#60 pr

* gslab-econ/template#60 fix syntax
* #91 first pass

* #91 improve warning message

* #91 second pass

* fix bug

* fix more bugs

* fix bugs and third pass

* fix bugs

* add in comments and options for path of git attributes

* first pass on debrief

* fix PR

* miss one file_name

* fix pr

* small edits

* implement debrief PR

* small edits
…th installation methods (#123)

* #122 test what pip does

* #122 cut some old code

* #122 abs path in setup.py

* #122 fix abs apth

* #122 Force uninstallation of all gslab tools at install time

* #123 #122 import site
… args (#124)

* Allow version and readme args in function call instead of sysagrv, update docs

* respond to PR
* #126 hit all checks, no documentation

* #126 fix overwrite of scons_local_path

* #126 docs

* #127 #126 small readme changes for PR

* #126 small fixes

* #127 #126 abstract text search, better config checks

* #127 #126 search dir not output for SConstruct
* #128 binding file limit on directory walk

* #131 purge provenance

* #131 first pass dir recording system

* #131 an SCons -> a SCons

* #131 change default log location

* #131 better naming, load into __init__, better prereq check

* #131 change default name for log

* #132 #131 change default log name

* #132 #131 gslab-econ/template#87 new log headding

* #132 #131 better path checks, fix walk-break rule, new path names

* #132 #131 fix heading creation of heading with hash
@@ -11,39 +11,42 @@
import _exception_classes
from size_warning import issue_size_warnings

def scons_debrief(target, env):
'''Execute functions after SCons has built all targets'''
def scons_debrief(args):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduce backward incompatibility, since the user has to modify SConstruct. @Shun-Yang I don't have a great grasp on this function and you were the last one to touch it, can you add a quick fix?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Comment as part of #130 #133

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change args['log'] back into the function argument as log = 'state_of_repo.log' but the reason we moved it is that this looks more compact and natural.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a discussion in the lab just now. Our solution is to provide a user-advisory that you cannot pass env and log to the function any longer and have to pass args, at which point we point to the current SConstruct in template. So we're fine with both 1) backward incompatibility and 2) coupled gslab_python/template for this particular problem.

@qlquanle
Copy link
Author

qlquanle commented Sep 12, 2017

gslab_python 4.1.0 Release Notes

Features

Misc

This was referenced Sep 12, 2017
Quan Le and others added 7 commits September 11, 2017 22:46
* change log exclusion syntax to proune

* #138 respond to pr
* gslab-econ/template#88 recursive fun to flatten dicts

* #88 PR, don't clobber repeated keys

* #88 cleaner string manipulation in flatten_dict
* #142 avoid collisions with sha1 hash of path

* #143 #142 fix source file removal
* #140 remove superfluous assett upload

* #140 swap order of git and scons check; note behavior in readme

* #140 format readme

* #141 #140 split up up_to_date, raise error if not up-to-date

* #141 #140 put elif after if

* #141 #140 output -> log

* #141 #140 add function to determine if scons is a dry run

* #140 try some logging stuff

* #141 #140 loggers get own files, toggle on scons dry-run
)

* #144 gslab-econ/template#96 working versions of clean builders

* #144 fix recursive cases when checking vers and multiple cuaght exception

* #144 small adjustments to anything builder

* #145 #144 switch order of args in builders

* #145 #144 cleaner access to default stata executable

* #145 #144 docstrings in prereq checks

* #145 #144 unscramble more target/source args in the builders
@arosenbe
Copy link
Contributor

arosenbe commented Mar 2, 2018

@stanfordquan, I think this is ready to go. Do you want to make the pull?

@qlquanle qlquanle merged commit bdce68d into master Mar 3, 2018
@yuchuan2016 yuchuan2016 deleted the 4.1.0 branch March 3, 2018 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants