-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for #26: Allow CL arguments to be passed #46
Conversation
Very cool @lboxell! Nice work. I have a few comments, but none of them relate (strongly) to the code you've written so far.
|
@arosenbe, Per discussion:
|
I've updated the unit tests. One of the release_tools tests still fails for me and I'm not sure what the issue is. Given there are other tasks open regarding the release module and refactoring the unit tests, I'm inclined to leave as-is (or have someone who knows what is going on with those tests take a look at it). My thoughts are that I'll update the template once I've updated the new gslab_scons module in master. |
Just checking in on this. |
@lboxell, sorry for the delay. I reran the tests after reinstalling a clean version of Your plan with the template sounds fine. |
I updated my mock installation and re-ran the tests successfully. I'm going to merge this branch now. |
@lboxell, it looks like you didn't make a release with the change. Could you? |
Done. |
See https://github.com/gslab-econ/template/tree/gslab_python-issue26_clarg for where I was testing this code.