Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate switch to SCons 3 #95

Closed
arosenbe opened this issue Jan 16, 2018 · 5 comments
Closed

Evaluate switch to SCons 3 #95

arosenbe opened this issue Jan 16, 2018 · 5 comments
Assignees
@Shun-Yang @lboxell @yuchuan2016 @arosenbe @qlquanle @AakaashRao

Comments

@arosenbe
Copy link
Contributor

SCons is currently on release 3.0.1. We're using 2.5.1, and that's behind by one major and one minor release. The goal of this task is to decide if we want to stick at 2.5.1 or update.

I don't think this would be a difficult change, since we can just drop in the newer scons local archive.

My sense is that most of the changes aren't relevant to us, with the possible exception of

3.0.0 should be slightly faster than 2.5.1. Changes yielded a 15% speed up for null incremental builds.

Thoughts?
@lboxell
Copy link
Contributor

lboxell commented Jan 16, 2018

My comments:

  • Looks like python3 is supported. That was one thing we had on the outline to reconsider once scons supported it.
  • Might cause rebuilds, but shouldn't be too much of an issue.
  • Didn't see any obvious reason not to.

@Shun-Yang
Copy link

I agree with @lboxell. I don't see any reason not to switch.

@yuchuan2016
Copy link
Contributor

Agree!

@Shun-Yang
Copy link

@arosenbe should we close this task and open a subsequent task to switch?

arosenbe added a commit that referenced this issue Feb 12, 2018
@arosenbe
#95 switch to scons 3
d19ddc8
@arosenbe
Copy link
Contributor Author

Update made and under PR at #97 by @Shun-Yang.

arosenbe added a commit that referenced this issue Feb 12, 2018
@arosenbe
#95 switch to scons 3 (#97)
53029e3
arosenbe added a commit that referenced this issue Mar 2, 2018
@arosenbe
Pull request for #96: Complete MG points 1-5 (#98)
0162177 
* #95 switch to scons 3

* .#96 update to new builders and config and rerun

* #96 drop _ before anything builder

* #98 #96 rerun with new builders

* #98 #96 typo in README

* #98 #96 better advertise package dependencies in config scripts

* #98 #96 mention reset config_user in README FAQ
qlquanle pushed a commit that referenced this issue Mar 3, 2018
4.1.0 Release (#85)
a820bdf 
* Pull request for #62: Separate sub-directory for analysis and paper/slides (#72)

* #62 reorganize repo

* #62 add provenance

* #62 allow provenance to check missing files

* #72 response to PR and comments

* #72 small name change

* Pull request for #67: Create release/lg for large files (#73)

* #67 add code to fake lg dataset, add lg to gitignore

* #67 add lg protocol to readme.md

* Update constants.yaml

* #67 blow up data file to do large release

* #67 change hist in default stata code to limit number of pins

* #67 delete old logs

* #67 readme change

* #67 manually copy new analysis files to paper input

* rerun paper-slides

* Pull request: move top level logs to release (#75)

* #61 first pass

* #61 second pass

* #61 switch to single quote

* #93 aux first pass

* #93 first pass

* #93 second pass

* Pull request for #61: restructure YAML in template  (#74)

* #61 first pass

* #61 second pass

* #61 switch to single quote

* #61 rm config_template

* add instruction on switching required softwares

* rm unused config_user_template

* #97 testing anything template

* gslab-python#97 demonstration scripts

* Pull Request for #66: Force integration with gslab_stata (#77)

* #66 revise stata scripts

* #66 modify README

* #66 small change in readme

* #66 add note in README

* gslab-python#97 change generator syntax

* gslab-python#97 respond to PR

* Pull Request for #64: Port example scripts to multiple languages (#76)

* #64 add examples for python stata matlab R, mute everything except python

* #64 add example of latex

* #64 modify dependencies

* #64 turn on git-lfs

* #64 response to PR

* #64 update readme and modify sample code

* solve conflict after merge

* rm accidental commit of local scripts

* Pull Request for #63: Make current dependencies optional (#78)

* #63 add builder check

* #63 add autimatic config scripts

* #63 response to PR

* #63 change the default to not upgrade

* #63 force installing of gslab_python

* #63 small change per PR

* #63 small change

* Pull request for creating size warning when git-lfs not presented (#79)

* first pass on template

* add in size warning for paper dir

* fix bugs

* add in option for git attributes

* add in paper dir

* Pull request for documenting and organizing debrief  (#81)

* #69 first pass

* implement PR

* small edits

* small edits

* Pull request for gslab_python#99: Add cache reconfiguration code (#83)

* gslab-econ/gslab_python#99 switch to scons local

* gslab-econ/gslab_python#99 delete scons local, lfs track .zip

* gslab-econ/gslab_python#99 commit scons-local-2.5.1

* gslab-econ/gslab_python#99 scons python scripts for each sub

* gslab-econ/gslab_python#99 remove top-level scons.zip

* #83 gslab-econ/gslab_python#99 update commands in readme.

* 83 gslab-econ/gslab_python#99 symlink to scons.py

* #83 gslab-econ/gslab_python#83 scons.py -> run.py, mention global scons in readme

* #83 gslab-econ/gslab_python#99 arg in main call

* Pull request for #82: Update docs for 4.1.0  (#84)

* #82 readme for 4.1.0, fix scons in paper_slides, build_anything in analysis

* #82 update data download procedure

* #82 add jupyter notebooks to .gitignore

* #82 build_anything demonstration

* #82 output

* #82 uncomment builder

* #84 #82 instructions to connect analysis and paper_slides

* #84 #82 respond to PR

* #84 #82 more PR

* change template

* Pull request for #86: Integrate make_provenance into SConstruct (#87)

* #86 incorporate external logging from gslab-econ/gslab_python#131

* #87 #86 PR

* #132 #131 delete stray file

* #87 #86 comment out some builders in analysis/SConstruct

* Pull request for #88: Grab all paths when recording inputs (#89)

* #88 allow inputs specificed as str or dict

* #88 fix sconscript after flatten input in config_global

* pep8 e713 change

* Pull request for #90: Load PYTHONPATH in SCons ENV (#91)

* #90 store pythonpath

* #90 remove stray pythonpath definition

* Fix location of sconstruct.log.

* Capitalization in readme

* Pull request for #92: Turn off default logging during SCons dry-run (#93)

* #92 turn off logging on dry run, uses gslab-econ/gslab_python#141

* #93 #92 move dry-run checking for logs into gslab_python

* Fix typo in readme

* #95 switch to scons 3 (#97)

* Update SCons local version in README

* practice task

* realized my mistake and reverting

* Pull request for #96: Complete MG points 1-5  (#98)

* #95 switch to scons 3

* .#96 update to new builders and config and rerun

* #96 drop _ before anything builder

* #98 #96 rerun with new builders

* #98 #96 typo in README

* #98 #96 better advertise package dependencies in config scripts

* #98 #96 mention reset config_user in README FAQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shun-Yang Shun-Yang

@lboxell lboxell

@yuchuan2016 yuchuan2016

@arosenbe arosenbe

@qlquanle qlquanle

@AakaashRao AakaashRao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Shun-Yang @lboxell @yuchuan2016 @arosenbe @qlquanle @AakaashRao