Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test project #1

Closed
wants to merge 1 commit into from

Conversation

viktor-podzigun
Copy link

Hi, thank you for looking at it.

I've put some comments on needed changes for each environment in build.sbt.

Thanks again and looking forward to your feedback.

@gslowikowski
Copy link
Owner

Thank you @viktor-podzigun

I have some questions:

  1. Why sbt-scalajs-bundler is required for JSDOMNodeJSEnv? Can't we create a project with this env, but without the bundler plugin?

  2. Does it make sense to fix scoverage plugin if for now we are not able to verify if it's working afterwards (because bundler needs patching)?

  3. I tried to create a project with PhantomJSEnv, but had strange java.lang.NoClassDefFoundError: org/eclipse/jetty/util/log/Logger error. Can you test this env as well?

At the end I'd like to test all ScalaJs environments.

P.S.
I don't know ScalaJs, learning it now, so please, be patient when I will ask dummy questions :)

@viktor-podzigun
Copy link
Author

Hi @gslowikowski,

  1. You are correct, sbt-scalajs-bundler is not required, it's just one more use case/env, since it contains custom JSDOMNodeJSEnv and many people using it we should support it as well (see discussion here).
    I've also created corresponding PR with required changes for standalone JSDOMNodeJSEnv :
    Added JSDOMNodeJSEnv.Config.exposeGlobal scala-js/scala-js-env-jsdom-nodejs#19

  2. If we agree on the approach, and the changes are compatible (no regression for current behaviour), I think, we are safe to apply the fix.

  3. It should not affect PhantomJSEnv , but I don't have experience with how to set it up correctly, maybe @sjrd could advise here?

You are doing great with scala.js, don't hesitate to ask, if you need any help!

@sjrd
Copy link

sjrd commented Mar 27, 2019

About PhantomJSEnv, don't bother: it's dying. PhantomJS itself is basically dead; its development has been officially suspended.

@viktor-podzigun
Copy link
Author

Closing in favor of scoverage/scalac-scoverage-plugin#456

@viktor-podzigun viktor-podzigun deleted the setup branch May 31, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants