Config Doc - Reinstate Reactive Oracle Client doc

In the end, let's keep it around but handles it properly in the generated config doc.
gsmet · Sep 10, 2024 · ac75ce9 · ac75ce9
1 parent c1ab892
commit ac75ce9
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/...nfig-doc-maven-plugin/src/main/java/io/quarkus/maven/config/doc/GenerateAsciidocMojo.java b/...nfig-doc-maven-plugin/src/main/java/io/quarkus/maven/config/doc/GenerateAsciidocMojo.java
@@ -10,4 +10,4 @@
  */
 @Mojo(name = "generate-asciidoc", defaultPhase = LifecyclePhase.GENERATE_RESOURCES, threadSafe = true)
 public class GenerateAsciidocMojo extends GenerateConfigDocMojo {
-}
+}
diff --git a/...fig-doc-maven-plugin/src/main/java/io/quarkus/maven/config/doc/GenerateConfigDocMojo.java b/...fig-doc-maven-plugin/src/main/java/io/quarkus/maven/config/doc/GenerateConfigDocMojo.java
@@ -111,9 +111,7 @@ public void execute() throws MojoExecutionException, MojoFailureException {
                 String topLevelPrefix = configRootEntry.getKey().topLevelPrefix();
                 ConfigRoot configRoot = configRootEntry.getValue();
 
-                if (configRoot.getNonDeprecatedItems().isEmpty()) {
-                    continue;
-                }
+                // here we generate a file even if there are no items as it's used for the Reactive Oracle SQL client
 
                 configRootPath = resolvedTargetDirectory.resolve(String.format(CONFIG_ROOT_FILE_FORMAT,
                         extension.artifactId(), topLevelPrefix, normalizedFormat.getExtension()));

diff --git a/...-plugin/src/main/resources/templates/asciidoc/default/configReference.qute.adoc b/...-plugin/src/main/resources/templates/asciidoc/default/configReference.qute.adoc
@@ -16,6 +16,9 @@ h|Default
 {#configProperty configProperty=item extension=extension additionalAnchorPrefix=additionalAnchorPrefix /}
 
 {/if}
+{#else}
+3+|No configuration properties found.
+
 {/for}
 |===
 

diff --git a/docs/src/main/asciidoc/datasource.adoc b/docs/src/main/asciidoc/datasource.adoc
@@ -952,7 +952,7 @@ include::{generated-dir}/config/quarkus-reactive-mssql-client.adoc[opts=optional
 
 ==== Reactive Oracle-specific configuration
 
-At the moment, there are no Oracle-specific configuration properties.
+include::{generated-dir}/config/quarkus-reactive-oracle-client.adoc[opts=optional, leveloffset=+1]
 
 ==== Reactive PostgreSQL-specific configuration
 

diff --git a/docs/src/main/asciidoc/reactive-sql-clients.adoc b/docs/src/main/asciidoc/reactive-sql-clients.adoc
@@ -922,7 +922,7 @@ include::{generated-dir}/config/quarkus-reactive-mssql-client.adoc[opts=optional
 
 === Oracle
 
-At the moment, there are no Oracle-specific configuration properties.
+include::{generated-dir}/config/quarkus-reactive-oracle-client.adoc[opts=optional, leveloffset=+1]
 
 === PostgreSQL
 

diff --git a/...c/main/java/io/quarkus/reactive/oracle/client/runtime/DataSourceReactiveOracleConfig.java b/...c/main/java/io/quarkus/reactive/oracle/client/runtime/DataSourceReactiveOracleConfig.java
@@ -5,5 +5,4 @@
 @ConfigGroup
 public interface DataSourceReactiveOracleConfig {
 
-    // when adding properties here, make sure you include the generated doc in datasource.adoc and reactive-sql-clients.adoc
 }