Allow using custom client #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gsquire could you please review it? |
|
Hey, I'm currently on vacation so I won't get to this until next week. Sorry! |
gsquire
reviewed
Aug 26, 2024
src/v3.rs
Outdated
| @@ -217,6 +217,17 @@ impl Sender { | |||
| self.host = host.into(); | |||
| } | |||
|
|
|||
| /// Sets client to use for the API. This is useful if you want to customize the client. | |||
| pub fn set_client(&mut self, client: Client) { | |||
There was a problem hiding this comment.
Maybe it would be better to allow new to accept an Option<Client> and just unwrap it or use a default one.
There was a problem hiding this comment.
Exactly. We'll need a new_blocking function as well so users can configure that client. Otherwise this LGTM.
|
Thanks! I will publish this as version 0.22.0 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be useful to make it possible to use custom client. (to customize networking options)