Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add effects "Hello, this is Agatha" & "Dave Here" #3528

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Rylxnd
Copy link
Contributor

@Rylxnd Rylxnd commented Aug 17, 2023

Fixes #3523, #2521, #2902, #3126, #3127, #3128 & #3153 😄


Once the effect(s) are triggered, the player will open their phone an receive a call. They are forced to take the call and can't hang up. (Don't worry the call isn't that long)

The effects should work with future patches, I finally figured out how to get the YSC globals. (Thanks Parik)

ChaosMod/Effects/db/Misc/MiscPhoneCall.cpp Outdated Show resolved Hide resolved
ChaosMod/Effects/db/Misc/MiscPhoneCall.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.h Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.cpp Outdated Show resolved Hide resolved
Rylxnd and others added 4 commits August 20, 2023 10:06
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
@Rylxnd Rylxnd requested a review from pongo1231 August 20, 2023 17:25
Copy link
Member

@pongo1231 pongo1231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the issue with the long delay between the global registration and finding it resolved?

ChaosMod/Components/Globals.h Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.h Outdated Show resolved Hide resolved
ChaosMod/Effects/db/Misc/MiscPhoneCall.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.h Outdated Show resolved Hide resolved
ChaosMod/Effects/db/Misc/MiscPhoneCall.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.h Outdated Show resolved Hide resolved
ChaosMod/Effects/db/Misc/MiscPhoneCall.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.cpp Outdated Show resolved Hide resolved
ChaosMod/Components/Globals.cpp Outdated Show resolved Hide resolved
Rylxnd and others added 6 commits August 26, 2023 17:25
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
Co-authored-by: pongo1231 <pongo1999712@gmail.com>
@Rylxnd Rylxnd requested a review from pongo1231 August 28, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Effect Improvement] Hello, this is Agatha
2 participants