-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement bindings for g_win32 functions #1042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
sdroege
reviewed
Mar 6, 2023
rmnscnce
added a commit
to rmnscnce/gtk-rs--gtk-rs-core
that referenced
this pull request
Mar 8, 2023
Link: gtk-rs#1042 (review) Signed-off-by: Paskal Sitepu <rmnscnce@ya.ru>
rmnscnce
added a commit
to rmnscnce/gtk-rs--gtk-rs-core
that referenced
this pull request
Mar 8, 2023
Refer to gtk-rs#1042 (review) Signed-off-by: Paskal Sitepu <rmnscnce@ya.ru>
sdroege
reviewed
Mar 9, 2023
rmnscnce
added a commit
to rmnscnce/gtk-rs--gtk-rs-core
that referenced
this pull request
Mar 9, 2023
Refer to: gtk-rs#1042 (review) Signed-off-by: Paskal Sitepu <rmnscnce@ya.ru>
sdroege
reviewed
Mar 11, 2023
@elmarco What do you think? |
elmarco
reviewed
Mar 13, 2023
sdroege
reviewed
Mar 14, 2023
sdroege
previously approved these changes
Mar 14, 2023
Needs a run of |
Please squash the commits while you are at it. |
rmnscnce
force-pushed
the
win32-bindings
branch
from
March 14, 2023 18:30
cd5f7d1
to
248b3f7
Compare
Thanks! |
bilelmoussaoui
added
the
needs-backport
PR needs backporting to the current stable branch
label
Mar 15, 2023
sdroege
removed
the
needs-backport
PR needs backporting to the current stable branch
label
Mar 15, 2023
Can't be backported because it changes API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to solve #2, I have tried to write wrappers for the
g_win32_*
functions.All of the functions listed on the issue have been implemented manually.