-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glib: Enable various smallvec features #1083
Conversation
This all require a newer rustc than what smallvec depends on, but much older than glib's minimum supported Rust version. Enabling these features enables smallvec to use less space, work with any array size and provide some more const functions.
Not sure what it has to do with the rest though. |
Especially the union feature makes a quite big difference and should be enabled by default. That can't be done though if you want to support rustc from 3 years ago. And your software depending indirectly on smallvec will have no way to enable it explictly unless you depend directly on smallvec (even if you don't use it), assuming you even notice that there is this configuration somewhere in one of your dependencies. |
Yes but it doesn't concern us so I'm really not sure to understand your point. |
In this case we're directly depending on it, so we "only" need to be aware that this configuration exists in our direct dependency. Which nobody did for 2 years, or did you? :) |
Ok I just got it: you said it because you realized that these features that improved this crate greatly were disabled by default because of MSRV. Now it makes sense. |
Sorry, I should've been more clear :) I had no breakfast yet! |
Go eat young man! |
This all require a newer rustc than what smallvec depends on, but much older than glib's minimum supported Rust version.
Enabling these features enables smallvec to use less space, work with any array size and provide some more const functions.
Another reason why conservative MSRV are the plague.