Regenerate with latest gir #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilelmoussaoui
commented
May 4, 2023
bilelmoussaoui
force-pushed
the
bilelmoussaoui/traits
branch
from
92e01c8
to
1ee0190
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/traits
branch
from
1ee0190
to
35261c4
Compare
| @@ -660,7 +660,7 @@ impl Pixbuf { | |||
| unsafe { FromGlibPtrContainer::from_glib_container(ffi::gdk_pixbuf_get_formats()) } | |||
| } | |||
|
|
|||
| #[cfg(any(feature = "v2_40"))] | |||
There was a problem hiding this comment.
That should be a clippy lint.
EDIT: I made myself a memo to add it.
sdroege
reviewed
May 4, 2023
| @@ -137,28 +137,15 @@ impl PixbufAnimation { | |||
| } | |||
| } | |||
|
|
|||
| pub trait PixbufAnimationExt: 'static { | |||
There was a problem hiding this comment.
Before merging this we should make sure that it's impossible for external code to implement these traits on anything. Otherwise we need to mark the trait unsafe or implement one of the many sealing mechanisms.
There was a problem hiding this comment.
I have opened #1093 to keep track of this task
There was a problem hiding this comment.
I think that is already happening as it requires IsA<T> and that is unsafe?
There was a problem hiding this comment.
Could we merge this now?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.