Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

CI: add a clippy job #30

Merged
merged 28 commits into from
Nov 19, 2020
Merged

CI: add a clippy job #30

merged 28 commits into from
Nov 19, 2020

Conversation

bilelmoussaoui
Copy link
Member

No description provided.

sdroege
sdroege reviewed Nov 8, 2020
View reviewed changes
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@sdroege
Copy link
Member

sdroege commented Nov 8, 2020

Good for me, once it passes. That might take some effort though, I don't think the crates above glib/gio are clippy clean. Maybe keep them as warnings for now until it's all cleaned up? That way we at least don't introduce new warnings.

@bilelmoussaoui
Copy link
Member Author

Good for me, once it passes. That might take some effort though, I don't think the crates above glib/gio are clippy clean. Maybe keep them as warnings for now until it's all cleaned up? That way we at least don't introduce new warnings.

I will run clippy locally and see the amount of work needed, I'm willing to put some time on it to get all the warnings cleared.

@sdroege sdroege added the ci label Nov 10, 2020
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/ci-clippy branch 7 times, most recently from 5f0c4b8 to 025c7ba Compare November 15, 2020 18:35
@bilelmoussaoui
Copy link
Member Author

@sdroege this one should be ready

sdroege
sdroege reviewed Nov 15, 2020
View reviewed changes
atk/src/lib.rs Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Nov 15, 2020
View reviewed changes
.github/workflows/CI.yml Outdated Show resolved Hide resolved
@sdroege
Copy link
Member

sdroege commented Nov 15, 2020

Seems ok to me otherwise, thanks!

@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/ci-clippy branch 7 times, most recently from ce980b8 to 39b8f4b Compare November 15, 2020 21:58
sdroege
sdroege reviewed Nov 16, 2020
View reviewed changes
.github/workflows/CI.yml Outdated Show resolved Hide resolved
sdroege
sdroege reviewed Nov 16, 2020
View reviewed changes
Copy link
Member

@sdroege sdroege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise now

@sdroege
Copy link
Member

sdroege commented Nov 16, 2020

Put a Fixes https://github.com/gtk-rs/gtk-rs/issues/17 into the commit message somewhere please :)

@sdroege sdroege mentioned this pull request Nov 16, 2020
Closed
@sdroege sdroege linked an issue Nov 16, 2020 that may be closed by this pull request
glib/translate: use matches! where applicable (see FIXME comments) #17
Closed
@sdroege
Copy link
Member

sdroege commented Nov 17, 2020

Good, the rust github action is currently broken...

bilelmoussaoui and others added 23 commits November 19, 2020 16:08
@bilelmoussaoui
gdk: fix clippy warnings
a433200
@bilelmoussaoui
pango: fix clippy warnings
4fb194b
@bilelmoussaoui
pangocairo: fix clippy warnings
f21f30c
@bilelmoussaoui
graphene: fix clippy warnings
9287dbb
@bilelmoussaoui
gdk-pixbuf: fix clippy warnings
31bb7d4
@bilelmoussaoui
glib: fix clippy warnings
030c2ed
@bilelmoussaoui
bump min rustc to 1.42.0
a68488e 
as we need matches! which was stabilized in v1.42.0
@bilelmoussaoui
gdkx11: fix clippy warnings
1087c04
@bilelmoussaoui
examples: fix clippy warnings
7ec265f
@bilelmoussaoui
gtk: fix clippy warnings
bd53b40
@bilelmoussaoui
misc: cleanup clippy linters
f0f5647
@bilelmoussaoui
misc: set missing unsafe doc per crate
b2a0354 
only for glib, gdk & cairo. other crates have very few them
this mostly to encourage documenting the safety of exported functions in the future
@bilelmoussaoui
clippy: run with --all-features
1991275 
this should lets us catch some behind feature flag clippy warnings
and fixes the current ones
@sdroege @bilelmoussaoui
ci: Run clippy with --all-targets
1e46c89
@sdroege @bilelmoussaoui
examples/clipboard_simple: Slightly clean up
5b7b30e
@sdroege @bilelmoussaoui
Fix a few other clippy warnings
5f24445
@bilelmoussaoui
CI: run clippy on rust-nightly
3227fbf 
due to the new feature(doc_cfg)
@bilelmoussaoui
glib: allow unused doc comments
07ec278 
as the doc(feature) are generated when there are no docs
@bilelmoussaoui
glib: return a BoolError for VariantTy
451e6d3
@bilelmoussaoui
glib: make ObjectImpl return a Value
fe8c818
@bilelmoussaoui
More clippy fixes
4e47323
@sdroege @bilelmoussaoui
gdk: Remove unnecessary lifetime annotations in ChangeData functions …
8d1c331 
…returning non-references
@sdroege @bilelmoussaoui
glib: Improve error string in VariantTy::new()
ee8edd3
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/ci-clippy branch from b1684a7 to ee8edd3 Compare November 19, 2020 15:09
@bilelmoussaoui
CI: split clippy jobs
ec7dbdc 
as we can't run clippy with --all-features & we can't specify --features
at workspace level, workaround it for now till we can re-use --all-features again
@bilelmoussaoui bilelmoussaoui force-pushed the bilelmoussaoui/ci-clippy branch from a7ed4eb to ec7dbdc Compare November 19, 2020 15:44
@bilelmoussaoui
Copy link
Member Author

@sdroege should be ready

@sdroege
Copy link
Member

sdroege commented Nov 19, 2020

Thanks, will merge in a few minutes :)

@sdroege sdroege merged commit ca08014 into master Nov 19, 2020
@sdroege sdroege deleted the bilelmoussaoui/ci-clippy branch November 19, 2020 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

@sdroege sdroege sdroege left review comments

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

glib/translate: use matches! where applicable (see FIXME comments)
3 participants
@bilelmoussaoui @sdroege @GuillaumeGomez