Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTopLevelPackage will now check DESCRIBES and DESCRIBED_BY relation… #979

Merged
merged 1 commit into from
Jun 29, 2023
Merged

getTopLevelPackage will now check DESCRIBES and DESCRIBED_BY relation… #979

merged 1 commit into from
Jun 29, 2023

Conversation

CrossedSecurity
Copy link
Collaborator

…ships to populate the pUrl. It will fall back to the original method of generating pUrl if neither are available. Added test cases for both of these options.

Fixes #708

This is a fresh branch for #857

Description of the PR

PR Checklist

  • [x ] All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • [ x] All new changes are covered by tests
  • [ x] If GraphQL schema is changed, make generate has been run
  • [ x] If collectsub protobuf has been changed, make proto has been run
  • [ x] All CI checks are passing (tests and formatting)
  • [ x] All dependent PRs have already been merged

lumjjb
lumjjb approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, else LGTM! Thanks @CrossedSecurity for helping with this!

pkg/ingestor/parser/spdx/parse_spdx.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/spdx/parse_spdx.go Outdated Show resolved Hide resolved
pkg/ingestor/parser/spdx/parse_spdx_test.go Show resolved Hide resolved
@CrossedSecurity CrossedSecurity force-pushed the spdx-describes-2 branch 2 times, most recently from 64b62be to 4b12f15 Compare June 28, 2023 16:45
@CrossedSecurity CrossedSecurity mentioned this pull request Jun 29, 2023
Closed
@CrossedSecurity
getTopLevelPackage will now check DESCRIBES and DESCRIBED_BY relation…
b3c37ac 
…ships to populate the pUrl. It will fall back to the original method of generating pUrl if neither are available. Added test cases for both of these options.

Fixes guacsec#708

Signed-off-by: Anthony LaCross <Anthony.lacross@gmail.com>
@kodiakhq kodiakhq bot merged commit 7164de2 into guacsec:main Jun 29, 2023
@lumjjb lumjjb mentioned this pull request Jun 29, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPDX parser top level heuristic change to check "DESCRIBES" relationship
3 participants
@CrossedSecurity @lumjjb @pxp928