Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API #397

wants to merge 1 commit into from

Conversation

rymai
Copy link
Member

@rymai rymai commented Jun 17, 2017

No description provided.

@rymai
Change Guard::RSpec to be a module and create Plugin which includes C…
2744758 
…ompat::API

Signed-off-by: Rémy Coutable <remy@rymai.me>
@rymai rymai changed the title Change Guard::RSpec to be a module and create Plugin which includes Compat::API [RFC] Change Guard::RSpec to be a module and create Plugin which includes Compat::API Jun 17, 2017
houndci-bot
houndci-bot reviewed Jun 17, 2017
View reviewed changes
spec/lib/guard/rspec/plugin_spec.rb

RSpec.describe Guard::RSpec do
RSpec.describe Guard::RSpec::Plugin do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block has too many lines. [72/25]

lib/guard/rspec/plugin.rb
@@ -0,0 +1,40 @@
module Guard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing magic comment # frozen_string_literal: true.

This was referenced Jun 17, 2017
Open
Open
@coveralls
Copy link

coveralls commented Jun 17, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-56.01%) to 42.225% when pulling 2744758 on guard-api into 1cf25c7 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-56.01%) to 42.225% when pulling 2744758 on guard-api into 1cf25c7 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rymai @coveralls @houndci-bot