Fix the test suite to run against latest Guard. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test suite works fine with Guard 2.1, but fails with Guard 2.13. The failure comes from heavy refactoring in recent version of Guard, where static initialization is expected by the runtime. The init just does not happen when running the test suite. guard-compat seems to address the problem, but it was not updated for a year at time of writing, and this commit is pretty simple in the end. The tests remain untouched and all pass.
|
@ic - see: rubocop#19 (This isn't the official fork of guard-rubocop - sorry for the confusion). |
|
@e2 Thank you for the pointer. I'll submit there, then. And perhaps you'll have some things to say about this request :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite works fine with Guard 2.1, but fails with Guard 2.13.
The failure comes from heavy refactoring in recent version of Guard,
where static initialization is expected by the runtime. The init just
does not happen when running the test suite.
guard-compat seems to address the problem, but it was not updated for a
year at time of writing, and this commit is pretty simple in the end.
The tests remain untouched and all pass.