Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in listen 3.0.2 + jruby #330

Closed
deivid-rodriguez opened this issue Jul 10, 2015 · 5 comments
Closed

Warnings in listen 3.0.2 + jruby #330

deivid-rodriguez opened this issue Jul 10, 2015 · 5 comments

Comments

@deivid-rodriguez
Copy link

I'm getting the following warnings. Just posting them here so you can evaluate if there's something to consider or it's better to just live with them

/home/davidr/.gem/jruby/2.2.2/gems/listen-3.0.2/lib/listen/event/queue.rb:15: warning: toplevel constant Queue referenced by Thread::Queue

/home/davidr/.gem/jruby/2.2.2/gems/listen-3.0.2/lib/listen/event/loop.rb:16: warning: toplevel constant Queue referenced by Thread::Queue

Regards!

@e2
Copy link
Contributor

e2 commented Jul 10, 2015

Thanks - this was reported before (in another issue), but I couldn't reproduce it.

I still couldn't reproduce it, but it should be fixed.

Can you confirm this branch fixes it?

gem 'listen', github: 'guard/listen', branch: 'e2-fix_toplevel_const_warning'

@deivid-rodriguez
Copy link
Author

It does! Thanks!!

@e2 e2 added the bug label Jul 10, 2015
@e2 e2 closed this as completed in ac7046c Jul 10, 2015
e2 added a commit that referenced this issue Jul 10, 2015
fix "toplevel constant" warnings [fixes #330]
@lustremedia
Copy link

Same warnings here. Any stable release where that is fixed?

Using listen (3.0.2)
Using guard (2.12.8)

@e2
Copy link
Contributor

e2 commented Jul 23, 2015

@lustremedia - released as 3.0.3 enjoy!

@lustremedia
Copy link

@e2 perfect, thanks!

@e2 e2 added the JRuby label May 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants