Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added correct link to help debug inotify workers error on linux #527

Merged

Conversation

williamkennedy
Copy link
Contributor

Pretty straightforward change.

On my CI build, the INOTIFY_LIMIT_MESSAGE was being displayed but the link was taking me to the wrong place.

It had me scratching my head for a few seconds until I read the readme.

Hope it helps.

@williamkennedy williamkennedy changed the title added correct link to help debig inotify workers error on linux added correct link to help debug inotify workers error on linux Dec 31, 2020
@ColinDKelley
Copy link
Collaborator

Oops, I accidentally broke that when I phased out the Wiki in favor of the README. Thanks for the fix!

I'll release this as part of v3.3.4 in the next day or two.

@ColinDKelley ColinDKelley merged commit 9cdacb7 into guard:master Dec 31, 2020
@williamkennedy
Copy link
Contributor Author

Oops, I accidentally broke that when I phased out the Wiki in favor of the README. Thanks for the fix!

I'll release this as part of v3.3.4 in the next day or two.

Awesome. I saw that the build was failing on macos and I was not sure why. Was going to have a look at it later but looks like you beat me to it.

@ColinDKelley
Copy link
Collaborator

@williamkennedy Glad you didn't spend time on the MacOS failure. It's just a slightly flakey test that seems to fail maybe 10% of the time. I've never seen it fail twice in a row.

I released both v3.3.4 and v3.4.0 just now. I separated them because v3.4.0 has a bit more risk to it (dependence on Linux-variant-specific monotonic clocks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants