Disable fail-fast for CI matrix #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ybiquitous I understand this disables "fail fast". But what is the problem if we leave "fail fast" enabled? |
|
@ColinDKelley Ah, sorry for the lack of why. I think it’s beneficial to disable fail-fast to make finding a problem with a specific OS or Ruby version easier. But, since disabling fail-fast may increase CI time, it’s a trade-off. |
|
Ah, that does seem like a tradeoff. And the biggest reason to have Fail Fast enabled would be if you were waiting for build results as soon as possible. Which I never am here. So I'm good with this change! |
|
@ColinDKelley Thank you for the review and merge! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to prevent canceling running jobs if some jobs fail.
See also: