Avoid modifying string literals #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used in an environment frozen string literals (for example: RUBYOPT="--enable=frozen-string-literal") modifying "" raises exceptions. This fixes that, by switching to String.new.
frederikspang
approved these changes
Aug 23, 2022
|
Thanks for the PR, version 0.11.2 has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running in an environment where strings are frozen by default (using
RUBYOPT="--enable=frozen-string-literal") and was getting exceptions.Switching to
String.newavoids this issue, without changing functionality.Before this PR, running tests using
RUBYOPT="--enable=frozen-string-literal rakeon this repo fails. After, it passes.