Tweak a couple of recipe fields to be arrays of strings instead of strings #244
Conversation
| 17: optional string suitableForDiet | ||
| 18: optional string cookingMethod |
There was a problem hiding this comment.
These are now backwards-incompatible changes, right? (Assuming you made a release with your previous changes.) Should we deprecate these fields and add new ones, instead?
There was a problem hiding this comment.
I know there shouldn’t be any existing data using these fields with these types, but maybe in the future someone might upgrade to the version we’ve just released that includes the incorrect types?
There was a problem hiding this comment.
@emdash-ie The thing is, Concierge will never actually generate data with this schema. So, if somebody does accidentally update to this version then they will get a 500 error if there is any (list) data in these fields.
That won't be an issue unless they have explicitly requested schema.org content with the schemaOrg=true parameter.
The difference is that Concierge will never have generated data in this form, so I think it's right to update the library asap before the incorrect version has the chance to spread.
What does this change?
Fixing a silly mistake with the thrift. Although it's usually a no-no to change the shape of thrift fields in this case we should be in the clear given it's not being used anywhere yet
How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility