-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency web-vitals to v3.0.0 #309
Conversation
🦋 Changeset detectedLatest commit: 1b62c14 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
88b7a0b
to
75da062
Compare
75da062
to
21ab322
Compare
2514d4a
to
57adc74
Compare
…to renovate/web-vitals-3.x
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. ⚠ Warning: custom changes will be lost. |
libs/@guardian/eslint-plugin-source-react-components/package.json
Outdated
Show resolved
Hide resolved
libs/@guardian/source-react-components-development-kitchen/package.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Sanders <alex@sndrs.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In practice the breaking changes from the peer dependency should be mentioned in this major release:
- Add a config object param to all metric functions (#225)
- Report TTFB after a bfcache restore (#220)
- Only include last LCP entry in metric entries (#218)
(sorry for the red tick, you only get one chance to draft major release notes)
These are covered in the Renovate notes, is that not sufficient? |
is it really the job of a lib to describe the breaking changes of internal dependencies? |
It should not be, but when you know the consumers don’t have strictly enforced peer dependencies, it might be the nice thing to do? |
added to changeset :) |
Note includes minor config change to work with this breaking change: https://togithub.com/GoogleChrome/web-vitals/pull/225
This PR contains the following updates:
2.0.0
->3.1.1
^2.0.0
->^2.0.0 || ^3.0.0
Release Notes
GoogleChrome/web-vitals
v3.1.1
Compare Source
onFCP()
callback (#297)v3.1.0
Compare Source
'restore'
as anavigationType
(#284)reportAllChanges
is true (#283)v3.0.4
Compare Source
v3.0.3
Compare Source
attribution
object is always present in attribution build (#265)v3.0.2
Compare Source
v3.0.1
Compare Source
v3.0.0
Compare Source
ReportHandler
type toReportCallback
, with alias for back-compat (#225, #227)getXXX()
functions toonXXX()
(#222)navigationType
property to the Metric object (#219)v2.1.4
Compare Source
v2.1.3
Compare Source
v2.1.2
Compare Source
v2.1.1
Compare Source
v2.1.0
Compare Source
v2.0.1
Compare Source
Configuration
📅 Schedule: Branch creation - "before 3am on Monday" in timezone Europe/London, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.