This repository has been archived by the owner on Apr 28, 2022. It is now read-only.
Remove jquery jasmine thus jquery dependency #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2013 13:41
jasmine.Fixtures.prototype.createContainer_ = function(html) in lib/jasmine-jquery.js assumes there is a body tag to append html to
its easy to add it to an individual project by adding a line like EnvJasmine.loadGlobal(EnvJasmine.testDir + "lib/jasmine-jquery.js"); to you test.dependencies.js not needed in the plugin though
|
one extra commit got in there but all it does it wrap the runner javascript in a body tag so jasmine jquery's Let me know if I should take it out and and make another branch with jus the one commit |
|
awesome guys! |
|
thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #9
If only for the benefit of having one less library in there to let get stale in there