Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass in the github org name via config #1310

Merged
merged 3 commits into from
Dec 11, 2024
Merged

pass in the github org name via config #1310

merged 3 commits into from
Dec 11, 2024

Conversation

NovemberTang
Copy link
Contributor

@NovemberTang NovemberTang commented Oct 24, 2024

What does this change?

Allows the github org name in dependency graph integrator to be configurable, similarly to #1271

Why?

Magic values are bad! And this will make it easier for people outside the guardian to use and modify the service catalogue if they wish.

How has it been verified?

  • CI passes.
  • CODE execution

Verified

This commit was signed with the committer’s verified signature.
Cogax Cogax
Copy link

This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days

@github-actions github-actions bot added the Stale label Nov 25, 2024
Copy link

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions bot closed this Nov 28, 2024
@NovemberTang NovemberTang reopened this Nov 28, 2024
@NovemberTang NovemberTang marked this pull request as ready for review November 28, 2024 11:07
@NovemberTang NovemberTang requested review from a team as code owners November 28, 2024 11:07
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on CODE and it worked as expected.

@NovemberTang NovemberTang merged commit 2b134c7 into main Dec 11, 2024
7 checks passed
@NovemberTang NovemberTang deleted the nt/dep-org-name branch December 11, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants